Give core should not cause PHP notice on PHP 8.0
complete
Ravinder Kumar
PHP code sniffer is throwing a few errors which can cause PHP notices on PHP 8.0. We can fix them before PHP 8.0 out [ November 26, 2020]
WPCS Output:
FILE: includes\admin\payments\payments-history.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
135 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $post_id is optional, while parameter $context
| | is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: includes\class-give-donor.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
1089 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $meta_key is optional, while parameter
| | $meta_value is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
1105 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $meta_key is optional, while parameter
| | $meta_value is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: includes\deprecated\deprecated-functions.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
488 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $form_id is optional, while parameter
| | $payment_id is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
549 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $give_form_id is optional, while parameter
| | $payment_id is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
780 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $form_id is optional, while parameter $amount
| | is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: includes\formatting.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
794 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $nonce is optional, while parameter $form_id
| | is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: includes\forms\functions.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
378 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $give_form_id is optional, while parameter
| | $payment_id is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
471 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $give_form_id is optional, while parameter
| | $amount is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
493 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $form_id is optional, while parameter $amount
| | is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: includes\payments\functions.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
585 | WARNING | Declaring a required parameter after an optional one is deprecated since PHP 8.0. Parameter $day is optional, while parameter $month_num
| | is required. (PHPCompatibility.FunctionDeclarations.RemovedOptionalBeforeRequiredParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------------------------------------------
Jason Adams
complete